fix: add optional type for file candidate data #340
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Where we know the type of content to be imported ahead of time (e.g. a Uint8Array or a stream, not both), it can be helpful to specify that type, so make `FileCandidate` generic to allow this. Defaults it to the previous `ImportContent` value so this is non-breaking.
github-actions bot
pushed a commit
that referenced
this pull request
Jun 30, 2023
## [ipfs-unixfs-importer-v15.1.6](ipfs-unixfs-importer-v15.1.5...ipfs-unixfs-importer-v15.1.6) (2023-06-30) ### Bug Fixes * add optional type for file candidate data ([#340](#340)) ([ac3d176](ac3d176))
|
🎉 This PR is included in version ipfs-unixfs-importer-v15.1.6 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Where we know the type of content to be imported ahead of time (e.g. a Uint8Array or a stream, not both), it can be helpful to specify that type, so make
FileCandidategeneric to allow this.Defaults it to the previous
ImportContentvalue so this is non-breaking.